rocco408 commented on code in PR #11419:
URL: https://github.com/apache/iceberg/pull/11419#discussion_r1834599748
##########
core/src/main/java/org/apache/iceberg/schema/UnionByNameVisitor.java:
##########
@@ -180,6 +179,21 @@ private void updateColumn(Types.NestedField field,
Types.NestedField existingFie
}
}
+ private boolean ignorableUpdate(Type newType, Type existingType) {
+ if (newType.isPrimitiveType()) {
+ if (newType.equals(existingType)) {
+ return true;
+ }
+ if (existingType.typeId() == Type.TypeID.LONG && newType.typeId() ==
Type.TypeID.INTEGER) {
Review Comment:
```shell
$ ./gradlew build -x test -x integrationTest
Configuration on demand is an incubating feature.
> Task :iceberg-open-api:validateRESTCatalogSpec
Validating spec
/Users/rocco/Github/iceberg/open-api/rest-catalog-open-api.yaml
Spec is valid.
> Task :iceberg-aws:validateS3SignerSpec
Validating spec
/Users/rocco/Github/iceberg/aws/src/main/resources/s3-signer-open-api.yaml
Spec is valid.
> Task :iceberg-core:checkstyleMain
[ant:checkstyle] [ERROR]
/Users/rocco/Github/iceberg/core/src/main/java/org/apache/iceberg/schema/UnionByNameVisitor.java:189:14:
Conditional logic can be removed. [SimplifyBooleanReturn]
> Task :iceberg-core:checkstyleMain FAILED
FAILURE: Build failed with an exception.
* What went wrong:
Execution failed for task ':iceberg-core:checkstyleMain'.
> A failure occurred while executing
org.gradle.api.plugins.quality.internal.CheckstyleAction
> Checkstyle rule violations were found. See the report at:
file:///Users/rocco/Github/iceberg/core/build/reports/checkstyle/main.html
Checkstyle files with violations: 1
Checkstyle violations by severity: [error:1]
* Try:
> Run with --scan to get full insights.
Deprecated Gradle features were used in this build, making it incompatible
with Gradle 9.0.
You can use '--warning-mode all' to show the individual deprecation warnings
and determine if they come from your own scripts or plugins.
For more on this, please refer to
https://docs.gradle.org/8.10.2/userguide/command_line_interface.html#sec:command_line_warnings
in the Gradle documentation.
BUILD FAILED in 12s
422 actionable tasks: 25 executed, 2 from cache, 395 up-to-date
```
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
