jbonofre commented on code in PR #11504:
URL: https://github.com/apache/iceberg/pull/11504#discussion_r1836010627
##########
azure/src/main/java/org/apache/iceberg/azure/AzureProperties.java:
##########
@@ -93,7 +93,7 @@ public void applyClientConfiguration(String account,
DataLakeFileSystemClientBui
if (connectionString != null && !connectionString.isEmpty()) {
builder.endpoint(connectionString);
} else {
- builder.endpoint("https://"; + account);
+ builder.endpoint("https://"; + account + ".dfs.core.windows.net");
Review Comment:
Should we really change add `.def.core.windows.net` by default ?
I mean that use currently include the suffix in `account` so it should be
clearly state that we append the suffix by default now.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
