RussellSpitzer commented on code in PR #11480:
URL: https://github.com/apache/iceberg/pull/11480#discussion_r1837044108
##########
spark/v3.5/spark-extensions/src/main/scala/org/apache/spark/sql/catalyst/parser/extensions/IcebergSparkSqlExtensionsParser.scala:
##########
@@ -151,6 +155,11 @@ class IcebergSparkSqlExtensionsParser(delegate:
ParserInterface) extends ParserI
isSnapshotRefDdl(normalized)))
}
+ private def isIcebergProcedure(normalized: String): Boolean = {
+ // All builtin Iceberg procedures are under the 'system' namespace
+ SparkProcedures.names().asScala.map("system." +
_).exists(normalized.contains)
Review Comment:
sorry I don't follow, the other example is part of a large chain
Is alter and
{
Thing 1
Thing 2
thing 3
}
There are no other parts of this? What is the benefit of having
isIcebergProcedure only check for the "system name"?
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
