aokolnychyi commented on code in PR #11485:
URL: https://github.com/apache/iceberg/pull/11485#discussion_r1837135723
##########
spark/v3.5/spark/src/test/java/org/apache/iceberg/spark/actions/TestRemoveOrphanFilesAction3.java:
##########
@@ -21,38 +21,37 @@
import static org.assertj.core.api.Assertions.assertThat;
import java.io.File;
-import java.util.Map;
+import java.util.concurrent.ThreadLocalRandom;
import java.util.stream.StreamSupport;
import org.apache.iceberg.actions.DeleteOrphanFiles;
-import org.apache.iceberg.relocated.com.google.common.collect.Maps;
import org.apache.iceberg.spark.SparkCatalog;
import org.apache.iceberg.spark.SparkSchemaUtil;
import org.apache.iceberg.spark.SparkSessionCatalog;
import org.apache.iceberg.spark.source.SparkTable;
import org.apache.spark.sql.connector.catalog.Identifier;
import org.apache.spark.sql.connector.expressions.Transform;
import org.junit.jupiter.api.AfterEach;
-import org.junit.jupiter.api.Test;
+import org.junit.jupiter.api.TestTemplate;
public class TestRemoveOrphanFilesAction3 extends TestRemoveOrphanFilesAction {
- @Test
+ @TestTemplate
public void testSparkCatalogTable() throws Exception {
spark.conf().set("spark.sql.catalog.mycat",
"org.apache.iceberg.spark.SparkCatalog");
spark.conf().set("spark.sql.catalog.mycat.type", "hadoop");
spark.conf().set("spark.sql.catalog.mycat.warehouse", tableLocation);
SparkCatalog cat = (SparkCatalog)
spark.sessionState().catalogManager().catalog("mycat");
String[] database = {"default"};
- Identifier id = Identifier.of(database, "table");
- Map<String, String> options = Maps.newHashMap();
+ Identifier id = Identifier.of(database, "table" +
ThreadLocalRandom.current().nextInt(1000));
Transform[] transforms = {};
- cat.createTable(id, SparkSchemaUtil.convert(SCHEMA), transforms, options);
+ cat.createTable(id, SparkSchemaUtil.convert(SCHEMA), transforms,
properties);
SparkTable table = (SparkTable) cat.loadTable(id);
- spark.sql("INSERT INTO mycat.default.table VALUES (1,1,1)");
+ spark.sql(String.format("INSERT INTO mycat.default.%s VALUES (1,1,1)",
id.name()));
Review Comment:
I think we should have `sql` method with formatting in the parent class.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
