nastra commented on code in PR #11514:
URL: https://github.com/apache/iceberg/pull/11514#discussion_r1850551275
##########
core/src/main/java/org/apache/iceberg/TableMetadata.java:
##########
@@ -562,10 +562,23 @@ public TableMetadata withUUID() {
return new Builder(this).assignUUID().build();
}
+ /**
+ * Updates the schema
+ *
+ * @deprecated since 1.8.0, will be removed 1.9.0 or 2.0.0, use
updateSchema(schema).
Review Comment:
```suggestion
* @deprecated since 1.8.0, will be removed in 1.9.0 or 2.0.0, use
updateSchema(schema).
```
##########
core/src/main/java/org/apache/iceberg/TableMetadata.java:
##########
@@ -1081,8 +1094,18 @@ public Builder setCurrentSchema(int schemaId) {
return this;
}
+ public Builder addSchema(Schema schema) {
+ addSchemaInternal(schema, schema.highestFieldId());
+ return this;
+ }
+
+ /**
+ * Add a new schema.
+ *
+ * @deprecated since 1.8.0, will be removed 1.9.0 or 2.0.0, use
AddSchema(schema).
Review Comment:
same as above
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
