neodon commented on code in PR #11552:
URL: https://github.com/apache/iceberg/pull/11552#discussion_r1851075235
##########
site/docs/spark-quickstart.md:
##########
@@ -100,7 +100,7 @@ services:
- AWS_ACCESS_KEY_ID=admin
- AWS_SECRET_ACCESS_KEY=password
- AWS_REGION=us-east-1
- entrypoint: >
+ entrypoint: |
Review Comment:
I tend to agree with you on "one line for one command". In this case,
however, there is one outer command that contains multiple inner commands. So
applying your criteria, would the inner commands be on separate lines?
There's also the issue of readability when my editor tries to format it.
With `>`, it doesn't change anything because the overall value is a valid
multiline block. With `|` and formatting, though, it becomes:
```bash
/bin/sh -c "until (/usr/bin/mc config host add minio http://minio:9000 admin
password) do echo '...waiting...' && sleep 1; done; /usr/bin/mc rm -r --force
minio/warehouse; /usr/bin/mc mb minio/warehouse; /usr/bin/mc policy set public
minio/warehouse; tail -f /dev/null"
```
I have trouble following that result. I have to work around the problem
somehow and fight my editor to keep it from changing that line. It's not a
concern for everyone, but most of my projects use format-on-save.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
