rdblue commented on code in PR #11626:
URL: https://github.com/apache/iceberg/pull/11626#discussion_r1861156965
##########
core/src/test/java/org/apache/iceberg/TestSnapshotJson.java:
##########
@@ -166,8 +166,14 @@ private String createManifestListWithManifestFiles(long
snapshotId, Long parentS
List<ManifestFile> manifests =
ImmutableList.of(
- new GenericManifestFile(localInput("file:/tmp/manifest1.avro"), 0),
- new GenericManifestFile(localInput("file:/tmp/manifest2.avro"),
0));
+ GenericManifestFile.copyOf(
+ new
GenericManifestFile(localInput("file:/tmp/manifest1.avro"), 0))
+ .withSnapshotId(snapshotId)
+ .build(),
Review Comment:
Minor: it looks like this is done quite a bit. What about making it easier
either with a test helper or a better builder?
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
