jasonf20 commented on code in PR #10962:
URL: https://github.com/apache/iceberg/pull/10962#discussion_r1861730623
##########
core/src/main/java/org/apache/iceberg/MergingSnapshotProducer.java:
##########
@@ -924,6 +934,7 @@ public List<ManifestFile> apply(TableMetadata base,
Snapshot snapshot) {
!= ManifestWriter
.UNASSIGNED_SEQ) // filter out unassigned in
rewritten manifests
.reduce(base.lastSequenceNumber(), Math::min);
+ long minDataSequenceNumber = Math.min(minNewFileSequenceNumber,
minExistingDataSequenceNumber);
Review Comment:
Sure looks good. I extracted it to a method and pushed.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
