Fokko commented on code in PR #11676:
URL: https://github.com/apache/iceberg/pull/11676#discussion_r1863459375
##########
.github/workflows/publish-iceberg-rest-fixture-docker.yml:
##########
@@ -42,14 +42,14 @@ jobs:
run: ./gradlew :iceberg-open-api:shadowJar
- name: Login to Docker Hub
run: |
- docker login -u ${{ secrets.DOCKERHUB_USER }} -p ${{
secrets.DOCKERHUB_TOKEN }}
+ docker login -u apache -p ${{ secrets.DOCKERHUB_TOKEN }}
- name: Set the tagged version
- # for tag 'apache-iceberg-1.7.0', publish image
'apache/iceberg-rest-fixture:1.7.1'
+ # for tag 'apache-iceberg-1.7.1', publish image
'apache/iceberg-rest-fixture:1.7.1'
if: github.event_name == 'push' && contains(github.ref, 'refs/tags/')
run: |
echo "DOCKER_IMAGE_VERSION=`echo ${{ github.ref }} | tr -d -c 0-9.`"
>> "$GITHUB_ENV"
- name: Build Docker Image
- run: docker build -t ${{ secrets.DOCKERHUB_USER
}}/$DOCKER_IMAGE_TAG:$DOCKER_IMAGE_VERSION -f
docker/iceberg-rest-adapter-image/Dockerfile .
+ run: docker build -t apache/$DOCKER_IMAGE_TAG:$DOCKER_IMAGE_VERSION -f
docker/iceberg-rest-fixture/Dockerfile .
Review Comment:
```suggestion
run: docker build -t
$DOCKER_REPOSITORY/$DOCKER_IMAGE_TAG:$DOCKER_IMAGE_VERSION -f
docker/iceberg-rest-fixture/Dockerfile .
```
##########
.github/workflows/publish-iceberg-rest-fixture-docker.yml:
##########
@@ -42,14 +42,14 @@ jobs:
run: ./gradlew :iceberg-open-api:shadowJar
- name: Login to Docker Hub
run: |
- docker login -u ${{ secrets.DOCKERHUB_USER }} -p ${{
secrets.DOCKERHUB_TOKEN }}
+ docker login -u apache -p ${{ secrets.DOCKERHUB_TOKEN }}
Review Comment:
As mentioned in the comment
https://github.com/apache/iceberg/pull/11673#issuecomment-2507538087 the user
and repository can be different if you're using an organization:
```suggestion
docker login -u ${{ secrets.DOCKERHUB_USER }} -p ${{
secrets.DOCKERHUB_TOKEN }}
```
##########
.github/workflows/publish-iceberg-rest-fixture-docker.yml:
##########
@@ -42,14 +42,14 @@ jobs:
run: ./gradlew :iceberg-open-api:shadowJar
- name: Login to Docker Hub
run: |
- docker login -u ${{ secrets.DOCKERHUB_USER }} -p ${{
secrets.DOCKERHUB_TOKEN }}
+ docker login -u apache -p ${{ secrets.DOCKERHUB_TOKEN }}
- name: Set the tagged version
- # for tag 'apache-iceberg-1.7.0', publish image
'apache/iceberg-rest-fixture:1.7.1'
+ # for tag 'apache-iceberg-1.7.1', publish image
'apache/iceberg-rest-fixture:1.7.1'
if: github.event_name == 'push' && contains(github.ref, 'refs/tags/')
run: |
echo "DOCKER_IMAGE_VERSION=`echo ${{ github.ref }} | tr -d -c 0-9.`"
>> "$GITHUB_ENV"
- name: Build Docker Image
- run: docker build -t ${{ secrets.DOCKERHUB_USER
}}/$DOCKER_IMAGE_TAG:$DOCKER_IMAGE_VERSION -f
docker/iceberg-rest-adapter-image/Dockerfile .
+ run: docker build -t apache/$DOCKER_IMAGE_TAG:$DOCKER_IMAGE_VERSION -f
docker/iceberg-rest-fixture/Dockerfile .
- name: Push Docker Image
run: |
- docker push ${{ secrets.DOCKERHUB_USER
}}/$DOCKER_IMAGE_TAG:$DOCKER_IMAGE_VERSION
+ docker push apache/$DOCKER_IMAGE_TAG:$DOCKER_IMAGE_VERSION
Review Comment:
```suggestion
docker push
$DOCKER_REPOSITORY/$DOCKER_IMAGE_TAG:$DOCKER_IMAGE_VERSION
```
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
