amogh-jahagirdar commented on code in PR #11561:
URL: https://github.com/apache/iceberg/pull/11561#discussion_r1863716254
##########
spark/v3.5/spark/src/main/java/org/apache/iceberg/spark/source/SparkPositionDeltaWrite.java:
##########
@@ -483,6 +493,14 @@ protected PartitioningWriter<PositionDelete<InternalRow>,
DeleteWriteResult> new
SparkFileWriterFactory writers,
OutputFileFactory files,
Context context) {
+ TableOperations ops = ((HasTableOperations) table).operations();
+ Function<CharSequence, PositionDeleteIndex> previousDeleteLoader =
+ rewritableDeletes != null
+ ? new PreviousDeleteLoader(table, rewritableDeletes)
+ : path -> null;
+ if (ops.current().formatVersion() >= 3) {
Review Comment:
I did the co-location and reused the context variable (went with using
context directly though in the useDVs check)
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
