nastra commented on code in PR #11661:
URL: https://github.com/apache/iceberg/pull/11661#discussion_r1865498503
##########
arrow/src/main/java/org/apache/iceberg/arrow/vectorized/parquet/VectorizedParquetDefinitionLevelReader.java:
##########
@@ -46,122 +47,217 @@ public VectorizedParquetDefinitionLevelReader(
super(bitWidth, maxDefLevel, readLength, setArrowValidityVector);
}
- abstract class NumericBaseReader {
- public void nextBatch(
+ abstract class CommonBaseReader {
+ protected void nextCommonBatch(
Review Comment:
why not leave that as `nextBatch()`? Does the `common` in the name help in
any way?
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
