wgtmac commented on code in PR #3: URL: https://github.com/apache/iceberg-cpp/pull/3#discussion_r1865982169
########## src/demo.cc: ########## @@ -0,0 +1,26 @@ +/* Review Comment: Personally I'm not in favor of splitting this repo into multiple libraries, which is an overkill. Originally I thought that the `api` and `core` folders from the apache/iceberg repo are all that we need. However, it seems that `puffin` is a good example which does not need to depend on other modules. Therefore I'm open to discuss. -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: [email protected] For queries about this service, please contact Infrastructure at: [email protected] --------------------------------------------------------------------- To unsubscribe, e-mail: [email protected] For additional commands, e-mail: [email protected]
