helmiazizm commented on code in PR #1392:
URL: https://github.com/apache/iceberg-python/pull/1392#discussion_r1866939185
##########
pyiceberg/io/pyarrow.py:
##########
@@ -350,7 +351,7 @@ def parse_location(location: str) -> Tuple[str, str, str]:
return uri.scheme, uri.netloc, f"{uri.netloc}{uri.path}"
def _initialize_fs(self, scheme: str, netloc: Optional[str] = None) ->
FileSystem:
- if scheme in {"s3", "s3a", "s3n"}:
+ if scheme in {"s3", "s3a", "s3n", "oss", "r2"}:
Review Comment:
`oss` is protocol for Alibaba Cloud Object Storage Service, and it's
[compatible with S3
API](https://www.alibabacloud.com/help/en/oss/developer-reference/use-amazon-s3-sdks-to-access-oss)
as long as the URL is in virtual address style.
From my quick test it looks like the class does support OSS, but not sure
yet about R2. Should I remove `r2` for now?
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
