amogh-jahagirdar commented on code in PR #10755:
URL: https://github.com/apache/iceberg/pull/10755#discussion_r1866324210
##########
core/src/main/java/org/apache/iceberg/TableMetadata.java:
##########
@@ -1108,6 +1108,25 @@ public Builder setDefaultPartitionSpec(int specId) {
return this;
}
+ Builder removeSpecIds(Iterable<Integer> specIds) {
Review Comment:
I think I'd prefer this should be called `removeSpecs`. If we look at the
other APIs on TableMetadata builder like `setDefaultPartitionSpec(int specId)`
it aligns with that naming, I don't think we need the "Ids" suffix.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
