nastra commented on code in PR #10753:
URL: https://github.com/apache/iceberg/pull/10753#discussion_r1870945455
##########
core/src/test/java/org/apache/iceberg/rest/TestRESTUtil.java:
##########
@@ -139,4 +148,100 @@ public void testOAuth2FormDataDecoding() {
assertThat(RESTUtil.decodeFormData(formString)).isEqualTo(expected);
}
+
+ @ParameterizedTest
+ @MethodSource
Review Comment:
we typically use explicit method names here rather than naming the argument
method and the test method the same.
```suggestion
@MethodSource("validRequestUris")
```
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
