nk1506 commented on code in PR #9184:
URL: https://github.com/apache/iceberg/pull/9184#discussion_r1871445945
##########
core/src/main/java/org/apache/iceberg/CatalogUtil.java:
##########
@@ -150,8 +154,7 @@ private static void deleteFiles(FileIO io,
Set<ManifestFile> allManifests) {
String type = reader.isDeleteManifestReader() ? "delete" :
"data";
deleteFiles(io, pathsToDelete, type, false);
} catch (IOException e) {
- throw new RuntimeIOException(
- e, "Failed to read manifest file: %s", manifest.path());
+ LOG.warn("Failed to read manifest file: {}", manifest.path(),
e);
Review Comment:
`IOException` can only be thrown by
[CloseableGroup](https://github.com/apache/iceberg/blob/36140b819c60743b39176e28a63ab588df445329/api/src/main/java/org/apache/iceberg/io/CloseableGroup.java#L75).
I’m struggling to find a better way to mock this call. Do you have any
suggestions?
Also, the current error message doesn’t seem very clear to me. It should be
something like:` Unexpected behavior: failed to close the resource.`
My intention was to ensure the operation doesn’t fail while deleting files.
However, if this exception is encountered, it might be safer to throw an RTE
rather than catching it. What do you think?”
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
