nastra commented on code in PR #11522:
URL: https://github.com/apache/iceberg/pull/11522#discussion_r1872742980
##########
core/src/main/java/org/apache/iceberg/rest/HTTPClient.java:
##########
@@ -465,10 +465,16 @@ static HttpClientConnectionManager
configureConnectionManager(Map<String, String
if (connectionConfig != null) {
connectionManagerBuilder.setDefaultConnectionConfig(connectionConfig);
}
+ Integer maxConnections = Integer.getInteger(REST_MAX_CONNECTIONS);
Review Comment:
rather than having the if statement, all of this can be inlined. See my
suggestion below
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
