ZENOTME commented on code in PR #738:
URL: https://github.com/apache/iceberg-rust/pull/738#discussion_r1873384095
##########
crates/iceberg/src/spec/manifest.rs:
##########
@@ -203,12 +206,80 @@ impl ManifestWriter {
partition_summary
}
- /// Write a manifest.
- pub async fn write(mut self, manifest: Manifest) -> Result<ManifestFile> {
+ /// Add a new manifest entry.
+ pub fn add(&mut self, mut entry: ManifestEntry) -> Result<()> {
Review Comment:
> If we to use ManifestEntry approach, we must have clear documentation
about the behavior of each part, e.g. which is ignored, which is reserved.
I agree with this. Then I think these functions can be `pub(crate)` to
ensure public users will not use it. I think for now there is no demand that
user need to use this API.🤔
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
