zhjwpku commented on code in PR #5:
URL: https://github.com/apache/iceberg-cpp/pull/5#discussion_r1873451868
##########
src/puffin/CMakeLists.txt:
##########
@@ -18,11 +18,10 @@
set(ICEBERG_PUFFIN_SOURCES demo_puffin.cc)
set(ICEBERG_PUFFIN_INCLUDES "${ICEBERG_API_DIR}")
-ADD_ICEBERG_LIB(
- iceberg_puffin
- CMAKE_PACKAGE_NAME
- puffin
- SOURCES
- ${ICEBERG_PUFFIN_SOURCES}
- PRIVATE_INCLUDES
- ${ICEBERG_PUFFIN_INCLUDES})
+add_iceberg_lib(iceberg_puffin
Review Comment:
> I simply used the `cmake-format` plugin in vscode with default setting
which formatted these CMake files.
Yeah, but we need to check the format when PRs are created, I did not
include the CI part because I not sure what is the best way to do it. We might
consider that together with clang-format.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
