nastra commented on code in PR #11729:
URL: https://github.com/apache/iceberg/pull/11729#discussion_r1876128938
##########
spark/v3.5/spark-extensions/src/test/java/org/apache/iceberg/spark/extensions/TestViews.java:
##########
@@ -562,6 +562,58 @@ public void readFromViewWithCTE() throws
NoSuchTableException {
assertThat(sql("SELECT * FROM %s",
viewName)).hasSize(1).containsExactly(row(10, 1L));
}
+ @TestTemplate
+ public void readFromViewWithGroupByOrdinal() throws NoSuchTableException {
Review Comment:
please also add a test where the view is entirely created through SQL:
```
@TestTemplate
public void createViewWithGroupByOrdinal() throws NoSuchTableException {
insertRows(10);
String viewName = viewName("createViewWithGroupByOrdinal");
sql("CREATE VIEW %s AS SELECT id FROM %s GROUP BY 1", viewName,
tableName);
List<Object[]> expected =
IntStream.rangeClosed(1,
10).mapToObj(this::row).collect(Collectors.toList());
assertThat(sql("SELECT * FROM %s", viewName))
.hasSize(10)
.containsExactlyInAnyOrderElementsOf(expected);
}
```
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
