amogh-jahagirdar commented on code in PR #11420:
URL: https://github.com/apache/iceberg/pull/11420#discussion_r1877295627
##########
aws/src/main/java/org/apache/iceberg/aws/AwsClientProperties.java:
##########
@@ -154,6 +156,23 @@ public AwsCredentialsProvider credentialsProvider(
return DefaultCredentialsProvider.builder().build();
}
+ /**
+ * Set ADAPTIVE_V2 <a
+ *
href="https://sdk.amazonaws.com/java/api/latest/software/amazon/awssdk/core/retry/RetryMode.html";>RetryMode</a>
+ * for an AWS client builder.
+ *
+ * <p>For more details, see
+ *
https://sdk.amazonaws.com/java/api/latest/software/amazon/awssdk/core/client/config/ClientOverrideConfiguration.Builder.html#retryStrategy(software.amazon.awssdk.core.retry.RetryMode)
+ */
Review Comment:
Could we structure this JavaDoc similar to the the other apply
configuration methods? e.g. checkout the java doc in
applyClientCredentialConfigurations or applyClientRegionConfiguration
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
