danielcweeks commented on code in PR #11597:
URL: https://github.com/apache/iceberg/pull/11597#discussion_r1879074770
##########
hive-metastore/src/main/java/org/apache/iceberg/hive/HiveCatalog.java:
##########
@@ -412,6 +412,43 @@ private void validateTableIsIcebergTableOrView(
}
}
+ /**
+ * Check whether table or metadata table exists.
+ *
+ * <p>Note: If a hive table with the same identifier exists in catalog, this
method will return
+ * {@code false}.
+ *
+ * @param identifier a table identifier
+ * @return true if the table exists, false otherwise
+ */
+ @Override
+ public boolean tableExists(TableIdentifier identifier) {
+ TableIdentifier baseTableIdentifier = identifier;
+ if (!isValidIdentifier(identifier)) {
+ if (!isValidMetadataIdentifier(identifier)) {
+ return false;
Review Comment:
Minor behavior issue here. Currently if it's an invalid identifier, it will
throw as opposed to returning false.
```
throw new NoSuchTableException("Invalid table identifier: %s", identifier);
```
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
