amogh-jahagirdar commented on code in PR #11693:
URL: https://github.com/apache/iceberg/pull/11693#discussion_r1880489562
##########
core/src/main/java/org/apache/iceberg/deletes/DVFileWriter.java:
##########
@@ -36,6 +36,22 @@ public interface DVFileWriter extends Closeable {
*/
void delete(String path, long pos, PartitionSpec spec, StructLike partition);
+ /**
+ * Marks every position that is deleted in positionDeleteIndex as deleted in
the given data file.
+ *
+ * @param path the data file path
+ * @param positionDeleteIndex the position delete index containing all the
positions to delete
+ * @param spec the data file partition spec
+ * @param partition the data file partition
+ */
+ default void delete(
Review Comment:
We could also make this interface take in a List<Long> positions (kind of
like a batch delete API on the writer) but it felt more natural to just pass in
the index imo, cc @aokolnychyi @nastra thoughts?
##########
core/src/main/java/org/apache/iceberg/io/OutputFileFactory.java:
##########
@@ -90,6 +91,11 @@ public static Builder builderFor(Table table, int
partitionId, long taskId) {
return new Builder(table, partitionId, taskId);
}
+ public static Builder builderFor(
+ TableOperations ops, PartitionSpec spec, FileFormat format, int
partitionId, long taskId) {
+ return new Builder(ops, spec, format, partitionId, taskId);
+ }
+
Review Comment:
Needed a way to create an output file factory from table operations since
that's all that exists in `MergingSnapshotProducer`, this is public so we need
to be careful.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
