szehon-ho commented on code in PR #11748:
URL: https://github.com/apache/iceberg/pull/11748#discussion_r1880821876
##########
spark/v3.5/spark/src/test/java/org/apache/iceberg/spark/actions/TestRewritePositionDeleteFilesAction.java:
##########
@@ -275,7 +275,7 @@ public void testRewriteFilter() throws Exception {
.execute();
List<DeleteFile> newDeleteFiles = except(deleteFiles(table), deleteFiles);
- assertThat(newDeleteFiles).as("Should have 4 delete files").hasSize(2);
+ assertThat(newDeleteFiles).as("Should have 2 delete files").hasSize(2);
Review Comment:
Question, should we just remove the number here, how about, 'delete files'?
Wont the assert message in the end already have the expected value from
hasSize()?
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
