nastra commented on code in PR #11577:
URL: https://github.com/apache/iceberg/pull/11577#discussion_r1881527842
##########
azure/src/main/java/org/apache/iceberg/azure/AzureProperties.java:
##########
@@ -90,7 +117,9 @@ public Optional<Long> adlsWriteBlockSize() {
*/
public void applyClientConfiguration(String account,
DataLakeFileSystemClientBuilder builder) {
String sasToken = adlsSasTokens.get(account);
- if (sasToken != null && !sasToken.isEmpty()) {
+ if (adlsRefreshCredentialsEnabled &&
!Strings.isNullOrEmpty(adlsRefreshCredentialsEndpoint)) {
Review Comment:
I think here you could just check whether `vendedAdlsCredentialProvider` is
not null
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
