c-thiel commented on code in PR #799:
URL: https://github.com/apache/iceberg-rust/pull/799#discussion_r1884298259
##########
crates/iceberg/src/catalog/mod.rs:
##########
@@ -446,6 +446,30 @@ pub enum TableUpdate {
/// Properties to remove
removals: Vec<String>,
},
+ /// Set statistics for a snapshot
+ #[serde(with = "_serde_set_statistics")]
+ SetStatistics {
+ /// File containing the statistics
+ statistics: StatisticsFile,
+ },
Review Comment:
In IRC and Java `SetStatistics` has an additional field `snapshot_id`
([link](https://github.com/apache/iceberg/blob/540d6a6251e31b232fe6ed2413680621454d107a/open-api/rest-catalog-open-api.yaml#L2902)).
This field is redundant with `StatisticsFile.snapshot_id` and is only used
as an [assertion in
Java](https://github.com/apache/iceberg/blob/540d6a6251e31b232fe6ed2413680621454d107a/core/src/main/java/org/apache/iceberg/TableMetadata.java#L1314).
I removed the redundancy for rust and will start a discussion on the mailing
List how to handle this.
As we still need to be spec compliant, we need custom serializer /
deserializer.
Slack:
https://apache-iceberg.slack.com/archives/C03LG1D563F/p1734109745807119
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
