corleyma commented on code in PR #1427:
URL: https://github.com/apache/iceberg-python/pull/1427#discussion_r1884536195
##########
pyiceberg/table/__init__.py:
##########
@@ -1423,6 +1451,66 @@ def plan_files(self) -> Iterable[FileScanTask]:
for data_entry in data_entries
]
+ def _target_split_size(self) -> int:
+ table_value = property_as_int(
+ self.table_metadata.properties, TableProperties.READ_SPLIT_SIZE,
TableProperties.READ_SPLIT_SIZE_DEFAULT
+ )
+ return property_as_int(self.options, TableProperties.READ_SPLIT_SIZE,
table_value) # type: ignore
+
+ def _loop_back(self) -> int:
+ table_value = property_as_int(
+ self.table_metadata.properties,
TableProperties.READ_SPLIT_LOOKBACK, TableProperties.READ_SPLIT_LOOKBACK_DEFAULT
+ )
+ return property_as_int(self.options,
TableProperties.READ_SPLIT_LOOKBACK, table_value) # type: ignore
+
+ def _split_open_file_cost(self) -> int:
+ table_value = property_as_int(
+ self.table_metadata.properties,
+ TableProperties.READ_SPLIT_OPEN_FILE_COST,
+ TableProperties.READ_SPLIT_OPEN_FILE_COST_DEFAULT,
+ )
+ return property_as_int(self.options,
TableProperties.READ_SPLIT_OPEN_FILE_COST, table_value) # type: ignore
+
+ def plan_task(self) -> Iterable[CombinedFileScanTask]:
Review Comment:
Also, assuming there's still some future plan to offload expensive stuff
like data scanning to a rust core, I do wonder if we want to commit to exposing
additional scan planning APIs that may not align with whatever query engine
gets embedded in pyiceberg?
In the case that this is primarily intended to be for the benefit of
pyiceberg's own scan execution I would consider making this a private API.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
