Fokko commented on code in PR #11775:
URL: https://github.com/apache/iceberg/pull/11775#discussion_r1888170004
##########
api/src/main/java/org/apache/iceberg/expressions/Literals.java:
##########
@@ -300,8 +300,7 @@ public <T> Literal<T> to(Type type) {
case TIMESTAMP:
return (Literal<T>) new TimestampLiteral(value());
case TIMESTAMP_NANO:
- // assume micros and convert to nanos to match the behavior in the
timestamp case above
- return new TimestampLiteral(value()).to(type);
+ return (Literal<T>) new TimestampNanoLiteral(value());
Review Comment:
I think both before and after this change is correct. In Iceberg we had the
assumption that _everything is in microseconds_. But this doesn't hold anymore
now we have nano's. I do think the version after the change is more correct and
more closely aligns with my expectations. If we can make sure that folks are
not using this yet, I think this change is a good one 👍
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
