nastra commented on code in PR #11751:
URL: https://github.com/apache/iceberg/pull/11751#discussion_r1888531567
##########
spark/v3.5/spark-extensions/src/test/java/org/apache/iceberg/spark/extensions/TestViews.java:
##########
@@ -1414,7 +1414,42 @@ public void describeExtendedView() {
String.format(
"['format-version' = '1', 'location' = '%s', 'provider' =
'iceberg']",
location),
- ""));
+ ""),
+ row("View Text", sql, ""));
+ }
+
+ @TestTemplate
+ public void describeExtendedViewWithoutCurrentNamespace() {
Review Comment:
> @nastra thanks for your suggestions, i added above tests. And do you think
it is necessary to modify
spark/v3.5/spark/src/main/java/org/apache/iceberg/spark/source/SparkView.java,
create view comand and desc extended view command?
@Ppei-Wang what exactly did you want to modify in the other places? All the
other places should be correct (because they refer to the default catalog that
was set when the view was created)
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
