kevinjqliu commented on code in PR #1426:
URL: https://github.com/apache/iceberg-python/pull/1426#discussion_r1889378149
##########
pyiceberg/table/name_mapping.py:
##########
@@ -232,7 +234,9 @@ def mapping(self, nm: NameMapping, field_results:
List[MappedField]) -> List[Map
def fields(self, struct: List[MappedField], field_results:
List[MappedField]) -> List[MappedField]:
reassignments: Dict[str, int] = {
- update.name: update.field_id for f in field_results if (update :=
self._updates.get(f.field_id))
+ update.name: update.field_id
+ for f in field_results
+ if f.field_id is not None and (update :=
self._updates.get(f.field_id))
Review Comment:
I see, is this change also due to the type checker?
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
