pan3793 commented on code in PR #11802:
URL: https://github.com/apache/iceberg/pull/11802#discussion_r1889513913
##########
spark/v3.5/spark/src/main/java/org/apache/iceberg/spark/data/vectorized/IcebergArrowColumnVector.java:
##########
@@ -59,6 +59,10 @@ public void close() {
accessor.close();
}
+ // If a column vector is writable or constant, it should override this
method and do nothing.
+ // See more details at SPARK-50235, SPARK-50463 (Fixed in Spark 3.5.4)
+ public void closeIfFreeable() {}
Review Comment:
> I don't think there's any value in adding this method without actually
being on Spark 3.5.4.
@nastra To not surprise users, I suppose
`iceberg-spark-runtime-3.5_2.12-1.7.2.jar` should work for Spark
3.5.x(unfortunately, it's not true for Spark 3.5.3 due to another issue), that
means, no matter which version it is built against, it's binary compatible with
a serial of versions of Spark 3.5.
In short, the value of this change is, to make the output
`iceberg-spark-runtime-3.3_2.12-<v>.jar` built against Spark 3.5.2, to be
compatible with Spark 3.5.4
##########
spark/v3.5/spark/src/main/java/org/apache/iceberg/spark/data/vectorized/IcebergArrowColumnVector.java:
##########
@@ -59,6 +59,10 @@ public void close() {
accessor.close();
}
+ // If a column vector is writable or constant, it should override this
method and do nothing.
+ // See more details at SPARK-50235, SPARK-50463 (Fixed in Spark 3.5.4)
+ public void closeIfFreeable() {}
Review Comment:
> I don't think there's any value in adding this method without actually
being on Spark 3.5.4.
@nastra To not surprise users, I suppose
`iceberg-spark-runtime-3.5_2.12-1.7.2.jar` should work for Spark
3.5.x(unfortunately, it's not true for Spark 3.5.3 due to another issue), that
means, no matter which version it is built against, it's binary compatible with
a serial of versions of Spark 3.5.
In short, the value of this change is, to make the output
`iceberg-spark-runtime-3.5_2.12-<v>.jar` built against Spark 3.5.2, to be
compatible with Spark 3.5.4
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
