wypoon commented on code in PR #11738:
URL: https://github.com/apache/iceberg/pull/11738#discussion_r1889531352
##########
core/src/main/java/org/apache/iceberg/CachingCatalog.java:
##########
@@ -144,14 +144,16 @@ public Table loadTable(TableIdentifier ident) {
return cached;
}
- if (MetadataTableUtils.hasMetadataTableName(canonicalized)) {
+ Table table = tableCache.get(canonicalized, catalog::loadTable);
+
+ if (table instanceof BaseMetadataTable) {
+ // Cache underlying table
TableIdentifier originTableIdentifier =
TableIdentifier.of(canonicalized.namespace().levels());
Table originTable = tableCache.get(originTableIdentifier,
catalog::loadTable);
- // share TableOperations instance of origin table for all metadata
tables, so that metadata
- // table instances are
- // also refreshed as well when origin table instance is refreshed.
+ // Share TableOperations instance of origin table for all metadata
tables, so that metadata
+ // table instances are also refreshed as well when origin table instance
is refreshed.
Review Comment:
I know you're simply reformatting an existing comment, but "also" is
redundant here:
"... are also refreshed as well..." -> "... are refreshed as well ...".
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
