rdblue commented on code in PR #11815:
URL: https://github.com/apache/iceberg/pull/11815#discussion_r1892693224
##########
spark/v3.5/spark/src/test/java/org/apache/iceberg/spark/data/AvroDataTest.java:
##########
@@ -248,17 +269,6 @@ public void testMixedTypes() throws IOException {
writeAndValidate(schema);
}
- @Test
- public void testTimestampWithoutZone() throws IOException {
Review Comment:
Removing this test for `TimestampNTZ` by adding the type to
`SUPPORTED_PRIMITIVES` (so that it is handled like any other primitive) is what
broke the ORC tests. It looks like the problem is that Spark 3.5's
`ColumnarRow` doesn't support `TimestampNTZType`. As a temporary work-around,
I've added validation code that checks the value by accessing it as a
`TimestampType` instead.
This isn't a change to read behavior, just how we access the data to
validate it. I expect to be able to remove this workaround in the next Spark
version.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
