jiakai-li commented on PR #1453: URL: https://github.com/apache/iceberg-python/pull/1453#issuecomment-2558702444
> BTW there are 2 FileIO implementations, one for pyarrow, another for fsspec. > > We might want to do the same for fsspec > > https://github.com/apache/iceberg-python/blob/dbcf65b4892779efca7362e069edecff7f2bf69f/pyiceberg/io/fsspec.py#L133-L141 Tested locally and also did some investigation. According to what I found [here](https://s3fs.readthedocs.io/en/latest/api.html#s3fs.core.S3FileSystem:~:text=cache_regions%20(bool%20(False))%20%E2%80%93%20Whether%20to%20cache%20bucket%20regions%20or%20not.%20Whenever%20a%20new%20bucket%20is%20used%2C%20it%20will%20first%20find%20out%20which%20region%20it%20belongs%20and%20then%20use%20the%20client%20for%20that%20region.) seems fsspec doesn't have the same issue as pyarrow. So I guess we can leave it? -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: [email protected] For queries about this service, please contact Infrastructure at: [email protected] --------------------------------------------------------------------- To unsubscribe, e-mail: [email protected] For additional commands, e-mail: [email protected]
