smaheshwar-pltr commented on PR #1457: URL: https://github.com/apache/iceberg-python/pull/1457#issuecomment-2560428546
Thanks a lot for this explanation and suggestion @kevinjqliu! It sounds good. Had some time so I've made this change so tests pass - using `make_compatible_name` as a param that can be specified on a per-case basis (instead of porting over all [this](https://github.com/apache/iceberg/blob/main/core/src/main/java/org/apache/iceberg/avro/AvroSchemaUtil.java#L507) logic into tests). I also made it `Optional` so each subtest doesn't have to specify the identity transform but `None`. -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: [email protected] For queries about this service, please contact Infrastructure at: [email protected] --------------------------------------------------------------------- To unsubscribe, e-mail: [email protected] For additional commands, e-mail: [email protected]
