liurenjie1024 commented on PR #824: URL: https://github.com/apache/iceberg-rust/pull/824#issuecomment-2560621001
> > I'm not a big fan of checking in Cargo.lock as it's an antipattern for library > > Just FYI that it's not considered an antipattern any more https://blog.rust-lang.org/2023/08/29/committing-lockfiles.html > > And e.g., opendal has it: https://github.com/apache/opendal/blob/main/core/Cargo.lock > > I don't have strong opinion and I'm OK with both though. Thanks for the reference, I wasn't aware of it. Would you mind to have a try with rust-cache? I'm not sure about the difference and it would be better to make decision with actual pr and result. -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: [email protected] For queries about this service, please contact Infrastructure at: [email protected] --------------------------------------------------------------------- To unsubscribe, e-mail: [email protected] For additional commands, e-mail: [email protected]
