ebyhr commented on code in PR #11864:
URL: https://github.com/apache/iceberg/pull/11864#discussion_r1896351505
##########
core/src/main/java/org/apache/iceberg/jdbc/JdbcCatalog.java:
##########
@@ -162,8 +162,8 @@ private void initializeCatalogTables() {
DatabaseMetaData dbMeta = conn.getMetaData();
ResultSet tableExists =
dbMeta.getTables(
- null /* catalog name */,
- null /* schemaPattern */,
+ conn.getCatalog() /* catalog name */,
+ conn.getSchema() /* schemaPattern */,
Review Comment:
The 2nd argument needs an escape. It's a pattern, not a name. This check
will fail if the similar schema exists, e.g. `dev` and `d_v`. Same for
`NAMESPACE_PROPERTIES_TABLE_NAME`. Please take a look at #11863
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
