rshkv commented on code in PR #846:
URL: https://github.com/apache/iceberg-rust/pull/846#discussion_r1897375800
##########
crates/iceberg/src/scan.rs:
##########
@@ -1019,7 +1022,7 @@ mod tests {
.metadata(table_metadata)
.identifier(TableIdent::from_strs(["db", "table1"]).unwrap())
.file_io(file_io.clone())
-
.metadata_location(table_metadata1_location.as_os_str().to_str().unwrap())
+ .metadata_location(template_json_location)
Review Comment:
Before this change, the location in the metadata log and the current
location would both be `../metadata/v1.json`.
I wanted to have a distinction so we can assert that `metadata_log_entries`
includes the current metadata location, even if not in the metadata log.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
