zhangdove commented on a change in pull request #1368:
URL: https://github.com/apache/iceberg/pull/1368#discussion_r478141385
##########
File path:
api/src/main/java/org/apache/iceberg/transforms/PartitionSpecVisitor.java
##########
@@ -55,17 +56,24 @@
} else if (transform instanceof Truncate) {
results.add(visitor.truncate(sourceName, field.sourceId(),
((Truncate<?>) transform).width()));
- } else if (transform == Dates.YEAR || transform == Timestamps.YEAR) {
+ } else if (transform == Dates.YEAR || isTimestamp(transform,
ChronoUnit.YEARS)) {
Review comment:
After modification,`timeZone` is already `final`.
Is there any validation work that needs to be done here?
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: issues-unsubscr...@iceberg.apache.org
For additional commands, e-mail: issues-h...@iceberg.apache.org
