Fokko commented on code in PR #1453:
URL: https://github.com/apache/iceberg-python/pull/1453#discussion_r1899068498
##########
pyiceberg/io/pyarrow.py:
##########
@@ -1508,7 +1512,7 @@ def _record_batches_from_scan_tasks_and_deletes(
if self._limit is not None and total_row_count >= self._limit:
break
batches = _task_to_record_batches(
- self._fs,
+ _fs_from_file_path(task.file.file_path, self._io),
Review Comment:
Nit: I noticed that we first pass in the path here, and the IO as a second
argument. For `_read_all_delete_files` it is the other way around. How about
unifying this?
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
