wgtmac commented on code in PR #6:
URL: https://github.com/apache/iceberg-cpp/pull/6#discussion_r1900325544
##########
cmake_modules/BuildUtils.cmake:
##########
@@ -182,13 +183,7 @@ function(ADD_ICEBERG_LIB LIB_NAME)
target_include_directories(${LIB_NAME}_static PRIVATE
${ARG_PRIVATE_INCLUDES})
endif()
- if(MSVC_TOOLCHAIN)
- set(LIB_NAME_STATIC ${LIB_NAME}_static)
- else()
- set(LIB_NAME_STATIC ${LIB_NAME})
- endif()
-
- set_target_properties(${LIB_NAME}_static PROPERTIES OUTPUT_NAME
${LIB_NAME_STATIC})
+ set_target_properties(${LIB_NAME}_static PROPERTIES OUTPUT_NAME
${LIB_NAME})
Review Comment:
It is installed, but to a different location (bin vs lib)
- C:/Users/runneradmin/AppData/Local/Temp/iceberg/bin/iceberg_arrow.dll
- C:/Users/runneradmin/AppData/Local/Temp/iceberg/lib/iceberg_arrow.lib
If I use `${LIB_NAME_STATIC}`, it will be
-
C:/Users/runneradmin/AppData/Local/Temp/iceberg/lib/iceberg_arrow_static.lib
I don't know how to let `iceberg_arrow.dll` reference to
`iceberg_arrow_static.lib` but not the default `iceberg_arrow.lib`
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
