bryanck commented on code in PR #11883:
URL: https://github.com/apache/iceberg/pull/11883#discussion_r1901077414
##########
kafka-connect/kafka-connect-runtime/src/integration/java/org/apache/iceberg/connect/IntegrationTestBase.java:
##########
@@ -55,6 +61,19 @@ public class IntegrationTestBase {
private KafkaProducer<String, String> producer;
protected static final int TEST_TOPIC_PARTITIONS = 2;
+ protected static final String TEST_DB = "test";
+ protected static final String TEST_TABLE1 = "foobar1";
Review Comment:
I feel we should keep the table name constants in the subclasses as well.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
