rshkv commented on code in PR #863:
URL: https://github.com/apache/iceberg-rust/pull/863#discussion_r1901741027
##########
crates/iceberg/src/metadata_scan.rs:
##########
Review Comment:
I agree but wasn't sure if that's just me being a Java dev 😄
##########
crates/iceberg/src/metadata_scan.rs:
##########
Review Comment:
There is no package or module split in the Java and Python implementations
so we'll need to make something up. I'd go with the SQL names of those tables
(combining with `all_*` tables):
```
inspect/
metadata_table.rs (with base traits)
entries.rs (with "entries" and "all_entries")
files.rs ("files", "all_files")
data_files.rs ("data_files" and "all_data_files")
delete_files.rs ("delete_files", "all_delete_files")
history.rs ("history")
metdata_log_entries.rs ("metadata_log_entries")
snapshots.rs ("snapshots")
refs.rs ("refs")
manifests.rs ("manifests", "all_manifests")
partitions.rs (with "partitions")
```
This might result in small-ish files but I think implementations will be
easy to find. We could maybe combine related tables but I think it'll make
things harder to find.
For reference, here are all metadata tables (from
[here](https://github.com/apache/iceberg/blob/4d35682295b6692a194b621e5afb880d9ccfab6f/core/src/main/java/org/apache/iceberg/MetadataTableType.java#L23C1-L39C20)):
```java
public enum MetadataTableType {
ENTRIES,
FILES,
DATA_FILES,
DELETE_FILES,
HISTORY,
METADATA_LOG_ENTRIES,
SNAPSHOTS,
REFS,
MANIFESTS,
PARTITIONS,
ALL_DATA_FILES,
ALL_DELETE_FILES,
ALL_FILES,
ALL_MANIFESTS,
ALL_ENTRIES,
POSITION_DELETES;
}
```
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
