grantatspothero commented on code in PR #11829:
URL: https://github.com/apache/iceberg/pull/11829#discussion_r1904696125
##########
core/src/test/java/org/apache/iceberg/TestTables.java:
##########
@@ -255,8 +257,13 @@ void failCommits(int numFailures) {
this.failCommits = numFailures;
}
+ int getMetadataFetchCount() {
Review Comment:
Why current/refresh counting is not great: cached metadata fetches are free
while uncached fetches are not, and this does not differentiate between the two.
Instrumenting at the fileio level would let us validate indeed only a single
uncached metadata request is needed for the whole commit.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
