HonahX commented on code in PR #11868:
URL: https://github.com/apache/iceberg/pull/11868#discussion_r1906484702
##########
api/src/main/java/org/apache/iceberg/types/Types.java:
##########
@@ -412,6 +413,24 @@ public String toString() {
}
}
+ public static class UnknownType extends PrimitiveType {
+ private static final UnknownType INSTANCE = new UnknownType();
Review Comment:
Hi @Fokko. I am working on a PR to add `UnknownType` support and just find
that you've already done the most important part here : ).
I wonder if we also want to also update
https://github.com/apache/iceberg/blob/821aec32bb9be28d9c1905f772d9e3101cc98d9e/api/src/main/java/org/apache/iceberg/Schema.java#L593-L607
in this PR to prevent users from adding UnknownType to v2 table schema? Is
it ok to do this in a separate PR and ensure both goes before the next release?
Tracking issue for UnknownType:
https://github.com/apache/iceberg/issues/11732
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
