zeroshade commented on code in PR #244:
URL: https://github.com/apache/iceberg-go/pull/244#discussion_r1907519396
##########
catalog/rest_test.go:
##########
@@ -114,6 +114,39 @@ func (r *RestCatalogSuite) TestToken200() {
r.Equal(r.configVals.Get("warehouse"), "s3://some-bucket")
}
+func (r *RestCatalogSuite) TestLoadRegisteredCatalog() {
+ r.mux.HandleFunc("/v1/oauth/tokens", func(w http.ResponseWriter, req
*http.Request) {
Review Comment:
Currently in the Rest catalog it's used as a fallback if there's no auth uri
set. If this is being deprecated, what should the workflow be if the authuri
isn't set and there's no credential or token set? Should it just error instead
of falling back to that?
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
