ajantha-bhat commented on code in PR #11904:
URL: https://github.com/apache/iceberg/pull/11904#discussion_r1908952177
##########
.palantir/revapi.yml:
##########
@@ -1171,6 +1171,28 @@ acceptedBreaks:
\ java.util.function.Function<T, java.lang.Long>,
org.apache.iceberg.io.CloseableIterable<java.lang.Long>,\
\ java.util.function.Consumer<T>)"
justification: "Removing deprecated code"
+ org.apache.iceberg:iceberg-parquet:
+ - code: "java.method.abstractMethodAdded"
+ new: "method
org.apache.iceberg.parquet.ParquetValueReaders.PrimitiveReader<?>\
+ \
org.apache.iceberg.data.parquet.BaseParquetReaders<T>::fixedReader(org.apache.parquet.column.ColumnDescriptor)"
+ justification: "{Refactor Parquet reader and writer}"
+ - code: "java.method.abstractMethodAdded"
+ new: "method
org.apache.iceberg.parquet.ParquetValueReaders.PrimitiveReader<?>\
+ \
org.apache.iceberg.data.parquet.BaseParquetReaders<T>::int96Reader(org.apache.parquet.column.ColumnDescriptor)"
+ justification: "{Refactor Parquet reader and writer}"
+ - code: "java.method.abstractMethodAdded"
+ new: "method
org.apache.iceberg.parquet.ParquetValueWriters.PrimitiveWriter<?>\
+ \
org.apache.iceberg.data.parquet.BaseParquetWriter<T>::fixedWriter(org.apache.parquet.column.ColumnDescriptor)"
+ justification: "{Refactor Parquet reader and writer}"
+ - code: "java.method.abstractMethodAdded"
+ new: "method
org.apache.parquet.schema.LogicalTypeAnnotation.LogicalTypeAnnotationVisitor<org.apache.iceberg.parquet.ParquetValueReader<?>>\
+ \
org.apache.iceberg.data.parquet.BaseParquetReaders<T>::logicalTypeReaderVisitor(org.apache.parquet.column.ColumnDescriptor,\
+ \ org.apache.iceberg.types.Type.PrimitiveType,
org.apache.parquet.schema.PrimitiveType)"
+ justification: "{Refactor Parquet reader and writer}"
+ - code: "java.method.abstractMethodAdded"
Review Comment:
New methods are abstract and abstract method cannot have default
implementation. So, I think we have to handle revapi failures.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
