smaheshwar-pltr commented on code in PR #1452:
URL: https://github.com/apache/iceberg-python/pull/1452#discussion_r1909309033
##########
tests/integration/test_writes/test_writes.py:
##########
@@ -285,6 +285,33 @@ def test_data_files(spark: SparkSession, session_catalog:
Catalog, arrow_table_w
assert [row.deleted_data_files_count for row in rows] == [0, 1, 0, 0, 0]
[email protected]
[email protected]("format_version", [1, 2])
+def test_object_storage_data_files(
Review Comment:
Hmm. I nit-ly prefer `test_object_storage_data_files`. Here's my reasoning:
for a test to be called that and check binary directories are present is
reasonable (it's what's expected from object storage data files). But the test
name specifying that detail reveals to much IMHO. (Happy to be overruled here).
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
