kevinjqliu commented on code in PR #1509:
URL: https://github.com/apache/iceberg-python/pull/1509#discussion_r1912162975
##########
tests/integration/test_writes/test_partitioned_writes.py:
##########
@@ -297,8 +297,8 @@ def
test_object_storage_location_provider_excludes_partition_path(
tbl = _create_table(
session_catalog=session_catalog,
identifier=f"default.arrow_table_v{format_version}_with_null_partitioned_on_col_{part_col}",
- # write.object-storage.partitioned-paths defaults to True
- properties={"format-version": str(format_version),
TableProperties.OBJECT_STORE_ENABLED: True},
+ # Both write.object-storage.enabled and
write.object-storage.partitioned-paths default to True
Review Comment:
wydt about adding assert statements as well? comments can become stale over
time
##########
pyiceberg/table/__init__.py:
##########
@@ -190,7 +190,7 @@ class TableProperties:
WRITE_PY_LOCATION_PROVIDER_IMPL = "write.py-location-provider.impl"
OBJECT_STORE_ENABLED = "write.object-storage.enabled"
- OBJECT_STORE_ENABLED_DEFAULT = False
+ OBJECT_STORE_ENABLED_DEFAULT = True # Differs from the Java implementation
Review Comment:
nit: instead of the comment here, let's add it to the docs
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
