pvary commented on code in PR #11948:
URL: https://github.com/apache/iceberg/pull/11948#discussion_r1912919783
##########
api/src/main/java/org/apache/iceberg/Snapshot.java:
##########
@@ -171,4 +171,27 @@ default Iterable<DeleteFile> removedDeleteFiles(FileIO io)
{
default Integer schemaId() {
return null;
}
+
+ /**
+ * The row-id of the first newly added row in this snapshot. The all rows
added in this snapshot
Review Comment:
maybe add something to highlight that this is valid only for newly added
rows. Updated rows can have smaller row-id.
Maybe (disclaimer English is not my first language):
```
The all newly added rows inserted in this snapshot will have a row-id value
of greater than or equal to this value. Only updated rows can have smaller
row-id in this snapshot.
```
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
